Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2: Not possible to type shift-T into a edit context in multiplayer #7783

Closed
JGRennison opened this issue Oct 20, 2019 · 1 comment
Closed

SDL2: Not possible to type shift-T into a edit context in multiplayer #7783

JGRennison opened this issue Oct 20, 2019 · 1 comment

Comments

@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Oct 20, 2019

Version of OpenTTD

Since 2d27e8e

Expected result

In multiplayer: pressing shift-T in the console, chat box or an text input dialog inputs a T character

Actual result

In multiplayer: pressing shift-T opens the chat box and replaces its contents.

Steps to reproduce

In multiplayer: pressing the shift and T keys at the same time

A possibly non-ideal fix is: JGRennison/OpenTTD-patches@87acac9

@nikolas
Copy link
Member

@nikolas nikolas commented Nov 1, 2019

Wow - really strange bug! Good catch. I'm not sure yet why this is happening. I'll take a look.

JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Nov 4, 2019
…it context

When in an edit context, input using only the shift key modifier
should not be interpreted as non-text input or as a hotkey.
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Nov 4, 2019
In particular this fixes handling of the shift key
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Nov 5, 2019
… context

In particular this fixes handling of the shift key
@LordAro LordAro closed this in a15ace0 Nov 10, 2019
douiwby added a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
… context

In particular this fixes handling of the shift key
spnda added a commit to spnda/OpenTTD that referenced this issue Jun 17, 2020
… context

In particular this fixes handling of the shift key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.