Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default openttd.cfg world gen settings don't allow Forests in Sub-Arctic #7872

Open
SamuXarick opened this issue Dec 22, 2019 · 7 comments
Open

Comments

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Dec 22, 2019

Version of OpenTTD

1.10.0-beta1

Expected result

Forests are generated

Actual result

Forests fail to generate

Steps to reproduce

  • Install a fresh OpenTTD
  • Run OpenTTD
  • Click New game
  • Select Sub-Arctic
  • Click Generate

I have in mind an easy fix for this, which would be decreasing the default Snowline to height 7 from 15, and change terrain type from Flat to Hilly.
Seems to never fail to generate forests this way. It also slightly improves Sub-Tropic landscape a tiny bit, with more rainforest area, instead of everything being desert.
EDIT: Actually, it's even better than I thought. With Flat terrain, it wasn't generating rivers in Sub-Tropic, but with Hilly, it does!

@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Dec 22, 2019

Others with same problem: #6448, #6392, #6337, #6072, #6035, #2148, #2128

Perhaps, another idea is making so that when terrain type is set to Flat, Very Flat (or even Hilly, Mountainous…) the snowline height gets automatically adjusted in order to be able to generate those industries.

SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Dec 22, 2019
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
@James103
Copy link
Contributor

@James103 James103 commented Dec 22, 2019

For an adaptive method, maybe add a flag, which when set (by the user), will adjust the snowline height based on the highest land height used by the map multiplied by a user-configurable percentage. For example: if the adaptive snowline level is set, the snowline height is set to 80%, and world landscape gen ends with a maximum land height of 20, then the snowline height will get set to 16, as that is 20 * 80%.

@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Dec 23, 2019

Some more findings. Variety distribution is off, map size is 256x256 with water on 4 borders.

TerraGenesis:

  • Very Flat terrain type fails to generate both Farms and Forests on Sub-Arctic. The height is not high enough.
  • Flat terrain type is sufficient to generate Farms and Forests with a snowline height ranging from 3 to 5.
  • Hilly terrain type is sufficient to generate Farms and Forests with a snowline height ranging from 3 to 7.
  • Mountainous terrain type is sufficient to generate Farms and Forests with a snowline height ranging from 3 to 13.

Original:

  • A snowline height must be a minimum of 4 or else Farms fail to generate, and a maximum of 13, or else Forests fail to generate, which means, ranging from 4 to 13.
@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Dec 27, 2019

SamuXarick@0217d1f

This is a patch which auto determines snow line height upon map generation. Since this discards user defined values, Snow Line Height is also removed from World Generation GUI.

In short, it tries to accomodate the snow line to a land mass of 50% snow but also ensures that all industries (namely farms and forests) can be generated on the map, giving them priority.

In general, Very Flat, and to a minor extent, Flat terrain types didn't have the required max height to accomodate Farms and Forests, so in order to have them on the map, these presets are generating higher heights than what's usual on the other landscape (non Sub-Arctic).

@James103
Copy link
Contributor

@James103 James103 commented Dec 27, 2019

@SamuXarick Applying this patch will mean that you will no longer be able to manually set the snowline height on world creation. Is there any way to only activate this patch on a user-defined basis? For example: "Snow line height = Auto" (which can be set by setting "Snow line height" to -1 or 0 (your choice)) will have the game automatically determine the snowline height, but "Snow line height = 10" will put the snow line at tile height 10.

@sheepo99
Copy link

@sheepo99 sheepo99 commented Dec 28, 2019

@James103 I'm personally fine with this, given that we don't get the option to pick the desert line in subtropical landscapes either. I favor a nice balance that always allows me to play the game to its fullest (loading all the industries proper in balanced amounts), over having a user-regulated setting that's prone to rendering a map unplayable, which is just bad design, IMO.

@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Dec 28, 2019

@James103 That can be done, but then there is a problem whenever you want it to always 'auto'. It wouldn't be able to remember that. Unless you add a new setting, a bool "auto_snow_level" on/off, to tell whether to use "snow_line_height" value or auto determine it. Nevermind, it actually remembers, because it's on a different category of settings (_settings_newgame vs _settings_game).

SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 3, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 8, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 8, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 11, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 11, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 12, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 19, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 6, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 23, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 23, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 24, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 29, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 13, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Apr 1, 2020
… terrain type raised to Hilly

- Results in better generated landscape for sub-arctic and sub-tropic with TerraGenesis on a clean Openttd.cfg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.