Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict in financial data. #7965

Open
autobus22 opened this issue Jan 28, 2020 · 3 comments
Open

Conflict in financial data. #7965

autobus22 opened this issue Jan 28, 2020 · 3 comments

Comments

@autobus22
Copy link

@autobus22 autobus22 commented Jan 28, 2020

Version:

1.9.3

Expect Result:

I expect to be getting consistent accurate financial statements about how my vehicles are performing.

What is occurring instead:

I am receiving conflicting information on the performance of my vehicles and lines and how much they are making/losing.

How to reproduce?

It appears to occur any time I play in this version, both with and without various NewGRF's on, Both on servers and in Singleplayer. (The specific save does use a few NewGRF's and is a save from playing on multiplayer.)

what2
what

BUGGED.zip

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jan 28, 2020

Are you using any cargo transfer, either via explicit orders or via cargodist? If you do, do you have any feeder share greater than 0% set?

As far as I remember, the Finances statement uses the actual income and running costs of vehicles, while the vehicle list window (group display) uses the per-vehicle profit this year figure which includes feeder share adjustments.
The feeder share adjustment is entirely "fake income", only the final delivery has real income, the transfer incomes are bookkeeping-tricks to make it look like the intermediate legs in the journey are contributing directly to the company profits.

@autobus22
Copy link
Author

@autobus22 autobus22 commented Jan 28, 2020

Yes, I do use cargodist: Practically all my services are feeders or have feeders.

The thing is: If that is why this is happening, then shouldn't we expect the actual income from the finances statement to be lower or identical in all cases: not higher as is happening with my road vehicles?

Thanks for the help.

Allthough: That's really annoying that you basically get conflicting income amounts that don't add up. :/

@frosch123
Copy link
Member

@frosch123 frosch123 commented Jan 29, 2020

There are 3 problems with comparing these numbers:

  1. If you sell/crash vehicles, they will be removed from the vehicle list, and no longer be included in the list and its sum.
  2. Refitting vehicles manually counts as running cost in the economy window, but does not affect the vehicle's profit. This is different to refitting via orders, which does affect the vehicle profit.
  3. The already mentioned problem with transfers:
    • The economy window shows the profit after the final delivery.
    • The vehicle list shows the profit of partial deliveries, the cargo may still be in transit in other vehicles.
    • These two numbers can differ in both directions by the total of your transport volume.
      • Cargo that was transported by some vehicles in the previous year, but finally delivered this year, will be added in total to the economy window, but only partially to the vehicle list (the rest was already accounted the previous year). This effect dominated in the beginning of the year.
      • Cargo that was transported by some vehicles this year, but has not yet reached its final destination, will be added to the vehicle list, but not yet to the economy window. The effect replaces the previous effect throughout the year.

Would these things explain the "big" difference in the amounts in your game?

About fixing:

  • (1) and (3) result in valid differences. I wouldn't know how this should be accounted differently.
  • About (2): I guess manual refitting should count as construction cost?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.