Skip to content

Ship automatic service causes them to be stuck in a loop #8022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SamuXarick opened this issue Feb 25, 2020 · 2 comments · May be fixed by #12170
Open

Ship automatic service causes them to be stuck in a loop #8022

SamuXarick opened this issue Feb 25, 2020 · 2 comments · May be fixed by #12170
Labels
bug Something isn't working component: pathfinder This issue is related to Pathfinder

Comments

@SamuXarick
Copy link
Contributor

SamuXarick commented Feb 25, 2020 •
edited
Loading

Version of OpenTTD

OpenTTD 20200223-master-gd1b7eb2de1 - Resolved by #11768
OpenTTD 20240128-master-g90084dc74d

Expected result

Ships either do service or not.

Actual result

Ships are stuck in a loop due to automatic servicing distance limit triggering it. They can't decide whether to head to ship depot or the dock, which are opposite directions.

Steps to reproduce

Charningstone Transport, 1960-11-25.zip - Resolved by #11768

Charningstone Transport, 1964-05-30.zip - Not resolved
@SamuXarick
Copy link
Contributor Author

SamuXarick commented Feb 25, 2020 •
edited
Loading

I have a fix for this which involves using the pathfinder, but the idea has been rejected in the past, which was before ship path cache. Is it perhaps worth approaching it again?
https://github.com/SamuXarick/OpenTTD/tree/find-closest-reachable-ship-depot

This was referenced Apr 12, 2021
Closed
Open
@2TallTyler 2TallTyler added component: pathfinder This issue is related to Pathfinder bug Something isn't working labels Oct 19, 2022
This was referenced Mar 5, 2023
Closed
Open
@SamuXarick
Copy link
Contributor Author

SamuXarick commented Jan 28, 2024 •
edited
Loading

Just found an edge case where this is still not resolved. See updated main topic.

Kuhnovic added a commit to Kuhnovic/OpenTTD that referenced this issue Feb 24, 2024
@Kuhnovic
Fix OpenTTD#8022: Ship automatic service causes them to be stuck in a…
fa2bc9e 
… loop
@Kuhnovic Kuhnovic linked a pull request Feb 24, 2024 that will close this issue
Open
Kuhnovic added a commit to Kuhnovic/OpenTTD that referenced this issue Sep 29, 2024
@Kuhnovic
Fix OpenTTD#8022: Ship automatic service causes them to be stuck in a…
5530c79 
… loop
Kuhnovic added a commit to Kuhnovic/OpenTTD that referenced this issue Oct 8, 2024
@Kuhnovic
Fix OpenTTD#8022: Ship automatic service causes them to be stuck in a…
b4532b7 
… loop
Kuhnovic added a commit to Kuhnovic/OpenTTD that referenced this issue Oct 11, 2024
@Kuhnovic
Fix OpenTTD#8022: Ship automatic service causes them to be stuck in a…
1ec0c67 
… loop
Kuhnovic added a commit to Kuhnovic/OpenTTD that referenced this issue Oct 11, 2024
@Kuhnovic
Fix OpenTTD#8022: Ship automatic service causes them to be stuck in a…
aed4c6a 
… loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component: pathfinder This issue is related to Pathfinder
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #8022: Ship automatic service causes them to be stuck in a loop Kuhnovic/OpenTTD
2 participants
@SamuXarick @2TallTyler