Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize NT 5.2 Service Pack 2 as supported in the installer #8057

Closed
chungy opened this issue Apr 3, 2020 · 5 comments
Closed

Recognize NT 5.2 Service Pack 2 as supported in the installer #8057

chungy opened this issue Apr 3, 2020 · 5 comments

Comments

@chungy
Copy link

@chungy chungy commented Apr 3, 2020

Version of OpenTTD

1.10.0

Expected result

The installer to run without complaining about minimum operating system version requirements.

Actual result

Installer complains that "You are trying to install [..] on Windows 95, 98, ME, 2000 and XP without SP3.", though it allows continuing past the warning.

Steps to reproduce

Install the game on ReactOS. Presumably this also happens on Windows Server 2003 and Windows XP x64 Edition, though I haven't tested the latter two cases.

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 3, 2020

Any support for Windows XP level Windows API implementation is coincidental, it's not something we aim to run on. None of our core developers have the time to test on operating systems that aren't their primary, so if the installer claimed to support ReactOS but the game by chance uses some API missing and wouldn't run/crashed, we'd never know.

A pull request resolving this would be welcome, but I wouldn't expect anyone on the core team to come up with something.

@chungy
Copy link
Author

@chungy chungy commented Apr 4, 2020

if the installer claimed to support ReactOS but the game by chance uses some API missing and wouldn't run/crashed, we'd never know.

It's not really about ReactOS even though that's where I noticed the issue. ReactOS itself aims to be and claims to applications that it is compatible with NT 5.2 SP2 (Windows Server 2003, XP x64). although from what I've seen, OpenTTD is fully functional, compatibility breaks are probably on ReactOS's part, not OpenTTD.

The main issue here is that the installer recognizes NT 5.1 SP3 (XP 32-bit) as compatible, and while NT 5.2 is a superset of API compatibility from that, the installer creates a warning when running on it.

Or maybe all Windows versions prior to some recent one (7?) are just untested and should be "unsupported" by OpenTTD. That would seem fair to me; it might happen to work, but without a guarantee of doing so.

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 4, 2020

Yes I should probably have written "anything earlier than Windows 7", I think that's the current intended target.

@glx22
Copy link
Contributor

@glx22 glx22 commented Apr 4, 2020

We just determine win9x or not using

Function GetWindowsVersion
GetVersion::WindowsPlatformArchitecture
Pop $R0
IntCmp $R0 64 WinNT 0
ClearErrors
StrCpy $R0 "win9x"
${If} ${IsNT}
${If} ${IsWinXP}
${AndIf} ${AtLeastServicePack} 3
${OrIf} ${AtLeastWin2003}
GoTo WinNT
${EndIf}
${EndIf}
GoTo Done
WinNT:
StrCpy $R0 "winnt"
Done:
Push $R0
FunctionEnd

And with #7270 the installer will be generated by CPack.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 1, 2021

Since CMake is merged, we no longer have a check like this anymore. So for our next release (1.11) this problem is resolved :)

@TrueBrain TrueBrain closed this Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants