Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New clients can't join (desync) after funding an industry #8137

Closed
ldpl opened this issue May 11, 2020 · 2 comments
Closed

New clients can't join (desync) after funding an industry #8137

ldpl opened this issue May 11, 2020 · 2 comments

Comments

@ldpl
Copy link
Contributor

@ldpl ldpl commented May 11, 2020

Version of OpenTTD

39092ee and 1.10.1

Expected result

No desync

Actual result

Connected clients stay, new clients desync almost instantly.

Steps to reproduce

Fund a coal mine as shown on the screenshot and start taking coal from the station.
Screenshot from 2020-05-11 15-18-05

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented May 11, 2020

According to the new coverage rule changes, coal shouldn't be moving to the station, but it is. :(

@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented May 11, 2020

I did some quick testing on my own patchpack but was not able to reproduce this. Looking back I'd already made a change to address this here: JGRennison/OpenTTD-patches@92c48d6, reverting this change causes the desync behaviour above and output from CheckCaches.

If this general approach is acceptable I can turn it into a PR.

ldpl added a commit to ldpl/OpenTTD that referenced this issue May 11, 2020
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue May 11, 2020
…lculation

This could result in stations being incorrectly added in the case of
non-rectangular industries where the station's catchment only
intersected with a non-industry tile subset of the overall rectangular
industry area.

This could cause multiplayer desyncs.
ldpl added a commit to ldpl/OpenTTD that referenced this issue May 11, 2020
ldpl added a commit to ldpl/OpenTTD that referenced this issue May 11, 2020
ldpl added a commit to ldpl/OpenTTD that referenced this issue May 11, 2020
ldpl added a commit to ldpl/OpenTTD that referenced this issue May 11, 2020
@LordAro LordAro closed this in f2a9a1e May 13, 2020
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants