Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadtype speed limit values are doubled in scenario editor drop-down menu #8155

Closed
Andrew350 opened this issue May 17, 2020 · 3 comments
Closed

Comments

@Andrew350
Copy link

@Andrew350 Andrew350 commented May 17, 2020

Version of OpenTTD

master-20200517

Expected result

Speed limits are displayed correctly

Actual result

Speed limits are not displayed correctly

Steps to reproduce

  • Load any roadtype NewGRF with speed limits (RattRoads is shown below)
  • Observe speeds shown in the scenario editor menu vs everything else

screenshot#1

The doubling effect only appears on this drop-down menu and does not appear to affect anything functionally; it is merely cosmetic and limited to the scenario editor.

@James103
Copy link
Contributor

@James103 James103 commented May 17, 2020

I believe I saw that even before 1.10.0 while I was modifying the Cindini scenario with roadtype NewGRFs.

@Yexo
Copy link
Contributor

@Yexo Yexo commented May 17, 2020

item->SetParam(1, rti->max_speed / 2);
(toolbar in normal game) has rti->max_speed/2 while
item->SetParam(1, rti->max_speed);
(toolbar in scenario editor) shows simply rti->max_speed.

Yexo pushed a commit to Yexo/OpenTTD that referenced this issue May 17, 2020
@James103
Copy link
Contributor

@James103 James103 commented May 17, 2020

So just a simple copy-paste error / typo in code?

@Yexo Yexo closed this as completed in 587d8e7 May 19, 2020
rasputino pushed a commit to rasputino/OpenTTD that referenced this issue Jun 1, 2020
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue Jun 1, 2020
LordAro pushed a commit that referenced this issue Jun 1, 2020
freprec pushed a commit to freprec/OpenTTD that referenced this issue Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants