Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible duplication of functionality in `screenshot.cpp` #8252

Open
techgeeknz opened this issue Jul 2, 2020 · 0 comments
Open

Possible duplication of functionality in `screenshot.cpp` #8252

techgeeknz opened this issue Jul 2, 2020 · 0 comments

Comments

@techgeeknz
Copy link
Contributor

@techgeeknz techgeeknz commented Jul 2, 2020

Version of OpenTTD

Since e04ca90

The introduction of the minimap screenshot feature appears to be duplicating functionality that will be used elsewhere for drawing the widgets within the minimap window; specifically, the GetMinimapOwner function is very likely to be replicating functionality used by the owner information overlay of the minimap window.

Expected result

We shouldn't have multiple codepaths that perform substantially similar functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.