Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTTD does not find GM.CAT when named uppercase. #8313

Closed
ipatix opened this issue Sep 21, 2020 · 2 comments
Closed

OpenTTD does not find GM.CAT when named uppercase. #8313

ipatix opened this issue Sep 21, 2020 · 2 comments

Comments

@ipatix
Copy link

@ipatix ipatix commented Sep 21, 2020

Version of OpenTTD

OpenTTD 1.10.3

Expected result

When I copy the GM.CAT file from the DOS version to get the original music it should be detected when named uppercase.

Actual result

The game does not find GM.CAT and does not show the music set in the settings.

Steps to reproduce

Pretty much what the title says: Copy the GM.CAT file from the original DOS version to the baseset/ folder. Probably only happens on Linux since Windows is case insensitive.

So what confused me most about this is that GM.CAT is clearly mentioned as uppercase in the README.md while the game is looking for a file in lowercase. Either it should be mentioned correctly in the README.md or the game should look for both filenames.

@FayneAldan
Copy link

@FayneAldan FayneAldan commented Sep 28, 2020

Yeah, this issue doesn't occur on Windows. I checked the baseset descriptions and it would appear that these files have incorrectly capitalized filenames:

As defined by both the readme and the original games' file structures, the DOS files should be uppercase and the Windows files should be lowercase; and as defined by just the readme, the TTO file should be uppercase.

FayneAldan pushed a commit to FayneAldan/OpenTTD that referenced this issue Sep 28, 2020
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Dec 15, 2020
Basically, systems that are case sensitive would otherwise not
been able to load without changing the cases. OpenTTD initial
tries the casing as given by the obg/obm/obs files, and if that
fails tries lowercase too.

So for those who already have the files lowercase, nothing
changes. For those that install fresh from TTO, it should now
work out-of-the-box.
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Dec 15, 2020
Basically, systems that are case sensitive would otherwise not
been able to load without changing the cases. OpenTTD initial
tries the casing as given by the obg/obm/obs files, and if that
fails tries lowercase too.

So for those who already have the files lowercase, nothing
changes. For those that install fresh from TTO, it should now
work out-of-the-box.
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Dec 15, 2020
DOS did not have cases in filenames. Different OS interpret
them as either all-lowercase or all-uppercase. So we try both.
All-uppercase is done by the obg/obm/obs files, and if opening
those files fail, OpenTTD will automatically retry the
all-lowercase variant.

So for those who already have the files lowercase, nothing
changes. For those that install fresh from TTO, it should now
work out-of-the-box.
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Dec 15, 2020
DOS did not have cases in filenames. Different OS interpret
them as either all-lowercase or all-uppercase. So we try both.
All-uppercase is done by the obg/obm/obs files, and if opening
fails, OpenTTD will automatically retry the all-lowercase variant.

So for those who already have the files lowercase, nothing
changes. For those that install fresh from TTO, it should now
work out-of-the-box.
@TrueBrain TrueBrain closed this in 88f30f7 Dec 15, 2020
@ipatix
Copy link
Author

@ipatix ipatix commented Dec 16, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants