Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of produced cargo for industries with multiple products are inaccurate #8316

Closed
no1wafer opened this issue Sep 25, 2020 · 2 comments
Closed

Comments

@no1wafer
Copy link

@no1wafer no1wafer commented Sep 25, 2020

Version of OpenTTD

1.10.3

Expected result

In Industries dialog, when doing Sort by Production on Produced cargo such as Oil, Livestock, and Grain, the sort order is exact for that product.

Actual result

The sorting is approximately in order
image

Steps to reproduce

Open Industries dialog, set Sort by to Production, change Produced cargo to Oil, Livestock, Grain, or Passenger

@stormcone
Copy link
Contributor

@stormcone stormcone commented Sep 25, 2020

This is caused by how the production sorter works. It takes into account the total amount of produced cargoes.
(1,000 litres of oil = 1 item, 1 passenger = 1 item, 1 tonne of coal = 1 item)
For example:
Tudningstone Oil Rig produces 336,000 litres of oil and 12 passengers, in total 348 items
Munford Oil Rig produces 342,000 litres of oil and 6 passengers, in total 348 items
Canley Oil Rig produces 315,000 litres of oil and 30 passengers, in total 345 items

Loading

@no1wafer
Copy link
Author

@no1wafer no1wafer commented Sep 25, 2020

Thanks for the reply.
I can understand that if I choose "All cargo types" the sorter combines the two cargoes, but shouldn't it just look at whatever is chosen when only one of them is selected?
Thanks!

Loading

SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Dec 29, 2020
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Dec 30, 2020
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Dec 30, 2020
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 5, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 6, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 10, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 18, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 18, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 18, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 21, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 5, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 10, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 29, 2021
@glx22 glx22 closed this in 26f7f59 Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants