Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Town builds unnecessary junctions on highway #8506

Open
kiwitreekor opened this issue Jan 5, 2021 · 8 comments
Open

Town builds unnecessary junctions on highway #8506

kiwitreekor opened this issue Jan 5, 2021 · 8 comments

Comments

@kiwitreekor
Copy link
Contributor

@kiwitreekor kiwitreekor commented Jan 5, 2021

Version of OpenTTD

1.10.3

Expected result

Towns should not build unnecessary junctions on highway (disallowed construction of houses along roadtype and disabled to be built by towns)

Actual result

image
Towns build unnecessary junctions

Steps to reproduce

  1. Build highway connected with town
  2. Wait until town grows
@Eddi-z
Copy link
Contributor

@Eddi-z Eddi-z commented Jan 5, 2021

"Highway" is not a default road in OpenTTD, so you might want to update your "steps to reproduce" by which NewGRFs need to be loaded.

@kiwitreekor
Copy link
Contributor Author

@kiwitreekor kiwitreekor commented Jan 6, 2021

I used Rattroad 1.0.2 to reproduce it, but it is reproducible with any newgrf which includes a roadtype with flag bit 2 set and bit 4 cleared.

@glx22
Copy link
Contributor

@glx22 glx22 commented Jan 6, 2021

Does it happen for all town layouts ?

@kiwitreekor
Copy link
Contributor Author

@kiwitreekor kiwitreekor commented Jan 6, 2021

image
2x2 layout
image
3x3 layout
image
Default layout

Yes, it happens.

@kiwitreekor
Copy link
Contributor Author

@kiwitreekor kiwitreekor commented Jan 6, 2021

I found that town can build roads after making junctions, I'm not sure whether this is intended or not.
In my opinion, It doesn't seem natural that a city can make a junction on a highway.

@glx22
Copy link
Contributor

@glx22 glx22 commented Jan 8, 2021

@kiwitreekor can you check if #8535 solves the issue ? (A preview is available for this PR): https://preview.openttd.org/pr8535/

@kiwitreekor
Copy link
Contributor Author

@kiwitreekor kiwitreekor commented Jan 9, 2021

#8535 fixes the issue, thanks!

TrueBrain pushed a commit that referenced this issue Jan 9, 2021
…build (#8535)
TrueBrain added a commit that referenced this issue Jan 9, 2021
… cannot build (#8535)"

This reverts commit b045666.
TrueBrain added a commit that referenced this issue Jan 9, 2021
…oads they cannot build (#8535)"

As per #8535 (comment),
jumped the gun here.
TrueBrain added a commit that referenced this issue Jan 9, 2021
…oads they cannot build (#8535)" (#8541)

As per #8535 (comment),
jumped the gun here.
@TrueBrain TrueBrain reopened this Jan 9, 2021
@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Jan 9, 2021

For reference I added a road/tram type flag in my branch to prevent towns from modifying tiles of a particular road/tram type. JGRennison/OpenTTD-patches@946442a
This is a bit more restrictive than the change proposed in #8535 in that it also covers some other town road operations such as removing free ends.
This sort of mechanism could be an alternative way of solving this.

I had highways (i.e. dual carriageway one way roads of a highway road type) in mind when I added this, but there are no GRFs using this as far as I aware.

2TallTyler added a commit to 2TallTyler/OpenTTD that referenced this issue Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants