Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused sounds #8619

Closed
Wuzzy2 opened this issue Jan 30, 2021 · 3 comments
Closed

Unused sounds #8619

Wuzzy2 opened this issue Jan 30, 2021 · 3 comments

Comments

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Jan 30, 2021

Version of OpenTTD

1.11.0-dev (4869840)

A couple of sounds are unused:

  • SND_0D_STEAM (OpenSFX: steam exhaust sound, like from a steam engine)
  • SND_11_CRASH (OpenSFX: light crash sound, less dramatic than the SND_13_BIG_CRASH sound)
  • SND_22_CAR_HORN (OpenSFX: empty sound)
  • SND_23_CAR_HORN_2 (OpenSFX: 'modern' car horn sound, twice)
  • SND_32_POP_2 (OpenSFX: empty sound; note that SND_2F_POP is the bubble pop for the Toyland bubble extraction)

Is it intentional or is this just an oversight?

@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 9, 2021

By the way: If the sounds are really intentionally unused in OpenTTD, I think the corresponding sound IDs should be marked in the source code (via code comments).

@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 19, 2021

OK. I was told by @frosch123 that the sounds are intentinoally unused. I therefore change the issue to this:

  • Add comments in source code to mark the unused sounds
@frosch123
Copy link
Member

@frosch123 frosch123 commented Feb 23, 2021

Done in #8701

@frosch123 frosch123 closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants