Unable to change townnames in Scenario editor after pr8566

[EratoNysiad]

Version of OpenTTD

pr8680, related to change in pr8566

Expected result

When placing towns in the scenario editor, you'd want to be able to change what townnames you're using. This used to be in the Game Options, but it's been moved to the terrain generation UI.

Actual result

It's no longer in the game options.

Steps to reproduce

Open OpenTTD in the mentioned version https://preview.openttd.org/pr8680/
Open up the scenario editor
Open up the town placement menu

[2TallTyler]

Scenario Editor uses the standard map generation window when generating a new random map or opening a heightmap. The only way to bypass this is if you choose the scenario type "Flat land" when creating a new scenario.

If you landscape the flat land to your liking and then realize the town names aren't set properly, you might assume you're stuck — although you can save the world as a heightmap and then open it again to get the full generation window.

I don't know how much of an edge case this would be. Sculpting from Flat land is just tedious and I've always built scenarios from heightmaps.

Also note that even when town names were in Options, the moment you placed your first town, your selected town name set was locked in. So there is not even a risk of a player losing hand-placed town or industries (which can't be placed without a parent town) if they have to save as a heightmap and reload. But this certainly isn't an obvious workaround.

I see two potential solutions:

• Add a town name selector to the Town Generation toolbar in SE
• Add a town name selector to the Flat land type landscape (not sure exactly how this would look) and always open the Scenario Type dialog before loading SE from the main menu to select Flat map or Random land.

Thoughts?

[EratoNysiad]

The first solution would quite quickly resolve the issue.

The second solution has an additional problem. If that's the new default starting window for the Scenario editor, then you'd also want a load scenario/heightmap button in the menu.

[frosch123]

The town-name generator is actually stored per town. In scenario-editor it is possible to use different name generators for different towns.
As such, adding it to the town-generation-toolbar, and possibly to the town-rename window makes most sense.