Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRF scanner progress updating no longer works due to _realtime_tick changes #8697

Closed
JGRennison opened this issue Feb 19, 2021 · 2 comments · Fixed by #8699
Closed

GRF scanner progress updating no longer works due to _realtime_tick changes #8697

JGRennison opened this issue Feb 19, 2021 · 2 comments · Fixed by #8699

Comments

@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Feb 19, 2021

Version of OpenTTD

Since d437445

Checked on SDL2 and Win32/WINE

It appears that DrawDirtyBlocks/HasModalProgress releases the locks so that the scanner thread can progress, but as _realtime_tick is no longer updated, the scanner thread will not release the locks to allow DrawDirtyBlocks/HasModalProgress to re-acquire them until all scanning has completed.

Expected result

NewGRF scanner window periodically updates at startup.

Actual result

NewGRF scanner does not update, the entire window is frozen until the scan completes.

Steps to reproduce

Run the game (preferably with lots of NewGRFs).

@glx22
Copy link
Contributor

@glx22 glx22 commented Feb 19, 2021

I can confirm the issue with my 1305 NewGRFs :)

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Feb 19, 2021

"oops".

Sorry :)

Happy you spotted this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants