Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Display referencing NewGRF set when query is used on rail, road and tram tiles #8779

Open
kevinfields777 opened this issue Mar 1, 2021 · 5 comments
Assignees
Labels
enhancement

Comments

@kevinfields777
Copy link

@kevinfields777 kevinfields777 commented Mar 1, 2021

Currently when you use the Land Area Information query tools on a tile with a NewGRF building or object on it, it will display which NewGRF the sprite comes from. This should be extended when querying rail, road and tram tiles.

@perezdidac
Copy link
Contributor

@perezdidac perezdidac commented Mar 1, 2021

I am happy to take ownership of this task, I think I know where to make the changes, will keep this thread posted.

@perezdidac
Copy link
Contributor

@perezdidac perezdidac commented Mar 1, 2021

image

Yeah I managed to do it, I will make sure this is maintainable and clean enough to be submitted and will send out a PR.

@2TallTyler
Copy link
Member

@2TallTyler 2TallTyler commented Mar 1, 2021

@perezdidac One case to consider, if you haven't already, is a road from one NewGRF and a tram track from another.

@perezdidac
Copy link
Contributor

@perezdidac perezdidac commented Mar 1, 2021

Yep I am totally considering it, changing a few things to be able to show the NewGRF for each track

@perezdidac
Copy link
Contributor

@perezdidac perezdidac commented Mar 9, 2021

Note for devs: plz assign this to myself, #8794 implements this.

@glx22 glx22 closed this as completed Mar 9, 2021
@glx22 glx22 reopened this Mar 9, 2021
@TrueBrain TrueBrain added the enhancement label Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

No branches or pull requests

5 participants