There are 17 places where "IConsoleError" can be used instead of "IConsolePrintF".

[James103]

Version of OpenTTD

9c5a7d3

Expected result

The function IConsoleError behaves exactly the same as using IConsolePrintF(CC_ERROR, "ERROR: %s", string);, but is shorter and more concise.

OpenTTD/src/console.cpp

Lines 168 to 171 in 9c5a7d3

	void IConsoleError(const char *string)
	{
	IConsolePrintF(CC_ERROR, "ERROR: %s", string);
	}

Therefore, IConsoleError(string) should in general be used instead of IConsolePrintF(CC_ERROR, "ERROR: %s", string).

Actual result

The following 14 occurrences of IConsolePrintF(CC_ERROR, "ERROR: %s", string) still exist:

OpenTTD/src/console_cmds.cpp

Lines 361 to 364 in 9c5a7d3

	IConsolePrintF(CC_ERROR, "%s: Not a savegame.", file);
	}
	} else {
	IConsolePrintF(CC_ERROR, "%s: No such file or directory.", file);

OpenTTD/src/console_cmds.cpp

Lines 385 to 388 in 9c5a7d3

	IConsolePrintF(CC_ERROR, "%s: Failed to delete file", file);
	}
	} else {
	IConsolePrintF(CC_ERROR, "%s: No such file or directory.", file);

OpenTTD/src/console_cmds.cpp

Lines 430 to 433 in 9c5a7d3

	default: IConsolePrintF(CC_ERROR, "%s: Not a directory.", file);
	}
	} else {
	IConsolePrintF(CC_ERROR, "%s: No such file or directory.", file);

OpenTTD/src/console_cmds.cpp

Line 487 in 9c5a7d3

IConsolePrintF(CC_ERROR, "ERROR: Silly boy, you can not %s yourself!", ban ? "ban" : "kick");

OpenTTD/src/console_cmds.cpp

Line 534 in 9c5a7d3

IConsolePrintF(CC_ERROR, "ERROR: Maximum kick message length is 254 characters. You entered " PRINTF_SIZE " characters.", kick_message_length);

OpenTTD/src/console_cmds.cpp

Line 558 in 9c5a7d3

IConsolePrintF(CC_ERROR, "ERROR: Maximum kick message length is 254 characters. You entered " PRINTF_SIZE " characters.", kick_message_length);

OpenTTD/src/console_cmds.cpp

Line 738 in 9c5a7d3

IConsolePrintF(CC_ERROR, "Company does not exist. Company-id must be between 1 and %d.", MAX_COMPANIES);

OpenTTD/src/console_cmds.cpp

Line 759 in 9c5a7d3

IConsolePrintF(CC_ERROR, "Company %d requires a password to join.", company_id + 1);

OpenTTD/src/console_cmds.cpp

Line 791 in 9c5a7d3

IConsolePrintF(CC_ERROR, "Company does not exist. Company-id must be between 1 and %d.", MAX_COMPANIES);

OpenTTD/src/console_cmds.cpp

Line 830 in 9c5a7d3

IConsolePrintF(CC_ERROR, "Company does not exist. Company-id must be between 1 and %d.", MAX_COMPANIES);

OpenTTD/src/console_cmds.cpp

Line 1577 in 9c5a7d3

IConsolePrintF(CC_ERROR, "ERROR: alias is of special type, please see its execution-line: '%s'", alias->cmdline);

Additionally, there are 3 additional occurrences of IConsolePrint(CC_ERROR, "ERROR: %s", string):

OpenTTD/src/console_cmds.cpp

Line 271 in 9c5a7d3

IConsolePrint(CC_ERROR, "Tile does not exist");

OpenTTD/src/console_cmds.cpp

Line 284 in 9c5a7d3

IConsolePrint(CC_ERROR, "Tile does not exist");

OpenTTD/src/console_cmds.cpp

Line 314 in 9c5a7d3

IConsolePrint(CC_ERROR, "Saving map failed");

Steps to reproduce

Look in the source of commands.cpp for the above occurrences.

[TrueBrain]

Have you ever considered making Pull Requests yourself? These kind of things are easy things to start with in a codebase like OpenTTD, and it seems you have a good grasp on what should happen/change?

Possibly also easier for yourself, as making these changes in code would have been faster than writing this ticket :D

Not saying you have to btw, I am perfectly fine with these tickets; I was just wondering :)

[TrueBrain]

PS : not all cases you highlight are "ERROR: " atm. But by the looks, most should be. So it is a two-for-oner :D

Example: IConsolePrint(CC_ERROR, "Saving map failed"); <- currently doesn't contain the word ERROR: :)

[TrueBrain]

IConsolePrintF(CC_ERROR, "%s: Not a savegame.", file); currently cannot be replaced with IConsoleError, as it doesn't use a plain string. I guess we need a IConsoleErrorF instead. Would make sense to me, to have that.

Looking over the list, all instances except for the last 3 are this, and this is also most likely the reason they are not IConsoleError yet. The last three are just silly, so they can be fixed easily :)

[AyushRaj8271]

Is this issue stilll available ?

[AyushRaj8271]

I would like to work on it !!