Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT_REACHED() crash when selling shared vehicles #8922

Closed
2TallTyler opened this issue Apr 1, 2021 · 1 comment · Fixed by #8926
Closed

NOT_REACHED() crash when selling shared vehicles #8922

2TallTyler opened this issue Apr 1, 2021 · 1 comment · Fixed by #8926

Comments

@2TallTyler
Copy link
Member

@2TallTyler 2TallTyler commented Apr 1, 2021

Version of OpenTTD

1.11.0-RC1

Expected result

Selling vehicles with shared orders does not crash the game.

Actual result

crash_reproduction

NOT_REACHED triggered at line 1719 of ..\src\vehicle_gui.cpp

Steps to reproduce

This is a tricky one to reproduce.

  1. In the attached savegame autosave14 (not the emergency save), open the New Mills Airport station (just north of the starting location in the savegame) and look at the list of trains with that station in its orders.
  2. Group the list by shared orders
  3. Train 289 is in the list, currently lost and near a depot. Click on it and send it to the depot
  4. In the depot, drag the last vehicle (an EMU) off the train onto a new line
  5. Click the Sell All button
  6. A NOT_REACHED error should trigger

crash_stuff.zip

@James103
Copy link
Contributor

@James103 James103 commented Apr 1, 2021

Can't reproduce the error in jgrpp-0.40.5 (perhaps one of @JGRennison's commits fixed it), but can reproduce in 088964a (2021-03-31 nightly) and 1.11.0 stable.

LordAro added a commit to LordAro/OpenTTD that referenced this issue Apr 1, 2021
LordAro added a commit to LordAro/OpenTTD that referenced this issue Apr 1, 2021
btzy added a commit to btzy/OpenTTD that referenced this issue Apr 2, 2021
btzy added a commit to btzy/OpenTTD that referenced this issue Apr 6, 2021
@LordAro LordAro closed this in #8926 Apr 6, 2021
LordAro added a commit to LordAro/OpenTTD that referenced this issue Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants