Crash on save on macOS

[smsm1]

Version of OpenTTD

1.11.0
zip download

Expected result

When saving the game, the game should continue.

Actual result

The game might be saved properly, the application crashes with the error:

Application Specific Information:
BUG IN CLIENT OF LIBDISPATCH: Assertion failed: Block was expected to execute on queue [com.apple.main-thread]

otp_crash.log

Steps to reproduce

1. Start or load a saved game
2. Play the game for a bit
3. Save the game
4. On clicking the save button when choosing the file name the game save file is created and then there is the crash.

I can reproduce this on both a Mac Mini 2018 Intel and MacBook Pro M1.

Previous versions (1.10.3) didn't have this issue.

[andythenorth]

Confirmed with 1.11.0. Haven't bisected, but a quick test of 1.11.0 Beta 2 didn't trigger this issue.

[smsm1]

e56d2c6 has the crash.
The commit parent of the above one i.e. 3a4a15c does not have the crash when compiling locally with cmake ..; make -j 8.

[michicc]

I'm currently unable to test this myself, but https://gist.github.com/michicc/1c6f8f0b5322c2cb8f0acc908d6b755a might possibly fix this issue.

[amf0336]

When a crash occurs during a save operation, the file can not be used to load a game.

Overwriting an existing save file always works.

[smsm1]

@michicc on master branch with your patch I have been unable to reproduce the crash and it is now working as expected. Without the patch the crash occurs.

@amf0336 I can confirm the behaviour that you are seeing too. With the above patch the issue goes away, as I've been able to load any of the files I've saved.

[michicc]

@smsm1 If it's not too much a bother, could you try the patch with both waitUntilDone:NO and waitUntilDone:YES? Principally, YES would be more correct, but I'm worried about it causing a thread stall.

I'm going to prepare a pull request tomorrow for this.

[smsm1]

When I use waitUntilDone:YES, when clicking save I get a beachball and openttd is completely unresponsive.

[michicc]

Thanks, then NO it is.

[rafalkrupinski]

I'm experiencing this bug, latest version, same message, but ONLY if I save by hitting enter in the save dialog

[TrueBrain]

Can you please create a new bug-report, with the crash log attached? It is possible, although the issues look alike, that they aren't. With a fresh bug-report and crash log we can look into that :)

Thank you!

[rafalkrupinski]

Can you please create a new bug-report

#9856