Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rivers going uphill are nearly impossible to distinguish from flat river #9031

Open
TrueBrain opened this issue Apr 12, 2021 · 11 comments
Open

Rivers going uphill are nearly impossible to distinguish from flat river #9031

TrueBrain opened this issue Apr 12, 2021 · 11 comments

Comments

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 12, 2021

Version of OpenTTD

1.11.0
OpenGFX

(I have no clue if this is OpenTTD graphics of OpenGFX graphics; feel free to move it to OpenGFX if it isn't OpenTTD).

Expected result

To see when my ship won't be able to get to the dock, because it had to go uphill, and I forgot to build a lock.

Ideally, rivers have a better animation which direction they flow. Now they just move a bit, looking like pixel-noise. But it doesn't show me a direction. I have no clue if this is possible at all, just saying what would have helped me out :)
Locks do have animation in the direction they are in btw, maybe helps for inspiration.

Actual result

Be totally confused for 30 minutes why my ship doesn't go to the dock.

Mainly, as ships don't have the greatest feedback they can't find a route: they will go towards the dock, but when it cannot go further, it turns around, drifts for a bit of time, then decides to go to the next order. If you are not closely watching your ship, you totally fail to see what is going on. Especially fun when you are building a big route :D

Steps to reproduce

Well, images say more:
image

image
Yes, this really goes uphill. Did you spot it?

Here it is without the trees:
image

This one got me the most. I have mad respect for people who draw tiles, but this one is just evil :)

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 12, 2021

That's OpenGFX graphics... I think. The "original" graphics looks like this. (Transport Tycoon Deluxe did not have rivers. They and canals are a TTDPatch feature adopted by OpenTTD, so the river graphics is new art drawn in Simon Foster's style.)

image

@TrueBrain
Copy link
Member Author

@TrueBrain TrueBrain commented Apr 12, 2021

Yeah, that is not a lot better, it seems. Also little indication of direction and that they are uphill.

I was also thinking, adding a path-indicator ships are going would also resolve the issue. I can then spot it cannot reach the dock. Like trains, but for boats :)

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 12, 2021

Yeah, I was playing TTD graphics and it's better than OpenGFX, but not a lot.

@glx22
Copy link
Contributor

@glx22 glx22 commented Apr 12, 2021

I confirm, original graphics a little better, but some are still very hard to spot
Capture d’écran 2021-04-12 222931
Capture d’écran 2021-04-12 223034
Capture d’écran 2021-04-12 223128

@James103
Copy link
Contributor

@James103 James103 commented Apr 13, 2021

Maybe make it so that on the river tile graphics, there are (very clearly visible and distinguishable) rocks on the river tile if and only if the river tile is sloped? That would entail removing any rocks (or what could look like rocks) from the not sloped portions of river graphics (if any), while adding and/or enlarging rocks present on the sloped river tile graphics.

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Apr 13, 2021

I can draw new, more visible rocks, and more white (turbulent) water. I don't know when, but it can be done.

@Eddi-z
Copy link
Contributor

@Eddi-z Eddi-z commented Apr 13, 2021

I think the main issue here is that there's no shading for the water, like there is for the grass

@auge8472
Copy link
Contributor

@auge8472 auge8472 commented Apr 13, 2021

For comparision the solution of michael blunck in his rivers NewGRF. The cataracts clearly marks the downhill sections.

mb-rivers

@tendersoft-mjb
Copy link

@tendersoft-mjb tendersoft-mjb commented Apr 20, 2021

I propose the simplest solution, make the water darker - in the particular examples below it's 14% darker.

I confirm, original graphics a little better, but some are still very hard to spot
Capture d’écran 2021-04-12 222931
openttd-darker-shade-of-sloped-water-01

Capture d’écran 2021-04-12 223034
openttd-darker-shade-of-sloped-water-02

Capture d’écran 2021-04-12 223128
openttd-darker-shade-of-sloped-water-03

@FLHerne
Copy link

@FLHerne FLHerne commented Apr 20, 2021

I propose the simplest solution, make the water darker - in the particular examples below it's 14% darker.

Unfortunately this doesn't work straightforwardly with palette animation -- the TTD palettes only contain one water cycle each, which doesn't leave much scope to change the colour while keeping animation. Non-animated slope tiles would look odd when all other water tiles are animated.

@rel1c
Copy link

@rel1c rel1c commented May 21, 2021

I propose the simplest solution, make the water darker - in the particular examples below it's 14% darker.

The water should be lighter in your first example, as the grass is as well when facing northeast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet