Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"File version" is incorrect for Windows OpenTTD executable #9062

Closed
James103 opened this issue Apr 19, 2021 · 7 comments · Fixed by #9066
Closed

"File version" is incorrect for Windows OpenTTD executable #9062

James103 opened this issue Apr 19, 2021 · 7 comments · Fixed by #9066

Comments

@James103
Copy link
Contributor

@James103 James103 commented Apr 19, 2021

Version of OpenTTD

OpenTTD 1.11.1 from the build artifacts for openttd-1.11.1-windows-win64 or openttd-1.11.1-windows-win32

Expected result

The "File version" that is part of the openttd.exe metadata should say 1.11.1.25330 (next: 1.11.2.25330).

Actual result

The "File version" that is part of the openttd.exe metadata says 1.11.0.25330. Reinstalling the game from the installer still leaves the value 1.11.0.25330 for the file version, and so does installing the game from the zip archive.

Steps to reproduce

  1. Download openttd-1.11.1-windows-win64 or openttd-1.11.1-windows-win32 (zip archive or installer) onto a Windows 10 device.
  2. Using Windows 10's File Explorer, look at the File version in the tooltip that comes up when you hover over openttd.exe.
  3. Notice that it says 1.11.0.25330 and not the expected 1.11.1.25330 (next: 1.11.2.25330).
@PeterN
Copy link
Member

@PeterN PeterN commented Apr 19, 2021

This is something that should be borne in mind for the future. It is obviously not possible to fix this for 1.11.1...

@glx22
Copy link
Contributor

@glx22 glx22 commented Apr 19, 2021

Quickly checked source, master also shows 1.11.0.xxxx

@LordAro
Copy link
Member

@LordAro LordAro commented Apr 19, 2021

Curious.

set(CPACK_PACKAGE_VERSION "@REV_VERSION@")

But REV_VERSION is definitely correct: https://github.com/OpenTTD/OpenTTD/runs/2375987432?check_suite_focus=true#step:12:115

CPACK_PACKAGE_VERSION is an internal cpack variable, perhaps it's getting confused/reused somehow?

@glx22
Copy link
Contributor

@glx22 glx22 commented Apr 19, 2021

ottdres.rc uses hard coded value, I'll see what I can do to fix that automatically.

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 19, 2021

make_installer.cmd for os2 and osx_stdafx.h for OS X are also hardcoded.

@glx22
Copy link
Contributor

@glx22 glx22 commented Apr 19, 2021

osx_stdafx.h doesn't contain openttd version, and for os2 every versions are hard coded, but I guess it should be possible to auto generate make_installer.cmd with correct openttd version.

@orudge
Copy link
Contributor

@orudge orudge commented Apr 19, 2021

The OS/2 installer stuff there is somewhat redundant; "modern" OS/2 appears to use RPM for package distribution. At some point I intend to update the OS/2 stuff, I'd just ignore it for now.

@glx22 glx22 closed this in #9066 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants