Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d4f0b6f requires cmake 3.12 #9156

Closed
MiguelHorta opened this issue May 1, 2021 · 0 comments · Fixed by #9154
Closed

d4f0b6f requires cmake 3.12 #9156

MiguelHorta opened this issue May 1, 2021 · 0 comments · Fixed by #9154

Comments

@MiguelHorta
Copy link
Contributor

MiguelHorta commented May 1, 2021

CMAKE_PROJECT_VERSION and related variables (CMAKE_PROJECT_VERSION_MAJOR, CMAKE_PROJECT_VERSION_MINOR, CMAKE_PROJECT_VERSION_PATCH) present in d4f0b6f were only introduced in cmake 3.12, yet cmake_minimum_required is set to 3.9

Currently systems that package cmake < 3.12 (e.g. Ubuntu 18.04) can still build the project but the binary produced is not usable for multiplayer due to version mismatch (only newgrf revision is different).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant