Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash]: Crashes when Multiplayer Opened #9501

Closed
Matu7865 opened this issue Aug 20, 2021 · 6 comments
Closed

[Crash]: Crashes when Multiplayer Opened #9501

Matu7865 opened this issue Aug 20, 2021 · 6 comments
Labels

Comments

@Matu7865
Copy link

@Matu7865 Matu7865 commented Aug 20, 2021

Version of OpenTTD

1.12.0 - Beta 2 Windows

Steps to reproduce

1.Opened the Game
2.Pressed Multiplayer
2.5.Pressed Ok on "Assertion failed at line 146 of D:\a\OpenTTD\src\network\network_client.cpp:
ClientNetworkGameSocketHandler::my_client == nullptr"
Errorcrash
3.Fatal Application Failure
Errorcrash2

Upload crash files

crashDatathingsMatu.zip
All of the Crash files

@LordAro
Copy link
Member

@LordAro LordAro commented Aug 20, 2021

Is this a new issue, or does it also occur in 12.0-beta1 ?

Loading

@LordAro LordAro changed the title [Crash]: Crashes when Multiplayer Opened [Crash]: Crashes when Multiplayer Opened Aug 20, 2021
@glx22
Copy link
Contributor

@glx22 glx22 commented Aug 20, 2021

 	[Code externe]	
>	openttd.exe!raise(int signum) Ligne 547	C++
 	openttd.exe!abort() Ligne 71	C++
 	openttd.exe!error(const char * s, ...) Ligne 147	C++
 	openttd.exe!ClientNetworkGameSocketHandler::ClientNetworkGameSocketHandler(unsigned __int64 s, const std::string & connection_string) Ligne 146	C++
 	openttd.exe!TCPQueryConnecter::OnConnect(unsigned __int64 s) Ligne 642	C++
 	openttd.exe!TCPConnecter::CheckActivity() Ligne 405	C++
 	openttd.exe!TCPConnecter::CheckCallbacks() Ligne 473	C++
 	openttd.exe!NetworkBackgroundLoop() Ligne 1022	C++
 	openttd.exe!GameLoop() Ligne 1456	C++
 	openttd.exe!VideoDriver::GameLoop() Ligne 37	C++
 	openttd.exe!VideoDriver::GameThread() Ligne 46	C++
 	openttd.exe!StartNewThread::__l3::<lambda>(const char * name, void(*)(VideoDriver *) && F, VideoDriver * && <A_0>) Ligne 65	C++
 	[Code externe]	
 	openttd.exe!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Ligne 97	C++
 	[Code externe]	

Loading

@agentw4b
Copy link

@agentw4b agentw4b commented Aug 20, 2021

I also opened this version of Openttd (Windows 10) and I got the exact same bug with the same message.

Loading

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Aug 20, 2021

This happens if a user has more than one server in their server-list.

When you open the Multiplayer window, it queries all servers in your server-list at once. The line of code that is being hit, prevents two server-connections pending at the same time (because, reasons). In result, when a connection to the second server is opened, it noticed there is already an open connection, and panics.

Not sure what a proper solution is, but at least knowing the cause is half the battle :)

Loading

@TrueBrain TrueBrain added the bug label Aug 20, 2021
@Matu7865
Copy link
Author

@Matu7865 Matu7865 commented Aug 20, 2021

It occurs in the 1.12.0-Beta 1 too.

Loading

TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Aug 21, 2021
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Aug 21, 2021

Steps to reproduce:

  • Start a local server
  • Start a local client
  • Add server 127.0.0.1 and 127.0.0.2 to your multiplayer list (yes, those all end up on your local server)
  • Close the client
  • Open the client again, hit Multiplayer window. Boom.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants