[Bug]: Incorrect sorting of vehicles by capacity

[LC-Zorg]

Version of OpenTTD

1.11.2 (also earlier)

Expected result

The game correctly sorts vehicles by capacity for the selected cargo (or all cargoes), starting with the vehicle with the highest maximum payload available, and ending with the vehicle with the lowest payload (or inversely) - the game takes into account all vehicle versions.

Actual result

When sorting by load capacity, the game probably takes into account the load capacity for the first version of the vehicle, which in the case of more complex sets results in an inappropriate, looking random order on the list.

The problem is clearly visible with the new Shark 1.0 ship set

It is similar in the other sets from the FISH series

Another example is in the Polroad set, which generally has some balance issues and may seem overly complex, but the list order is not correct anyway. It's hard to see the sorting logic here.

Steps to reproduce

Description above

[LordAro]

In a way, this is actually just a misunderstanding - the sorting the vehicle list by cargo only sorts by the default cargo. The cargo filter is separate, and only meant for filtering the list, not affecting sort order.

It's definitely confusing though

[LordAro]

And of course, the existing sorter functions have no access to the selected cargo type at all, which would make fixing this "painful" to say the least.

[andythenorth]

Low likelihood of fix, would require something like

• running cb36 for all available vehicles
• running cb12 for all available vehicles
• making a decision about whether to try and guess / handle cargo subtypes for all available vehicles
• going through these flow controls to find all the edge cases https://newgrf-specs.tt-wiki.net/wiki/VehicleRefitting

Not likely to happen, closing, thanks for report.

[LC-Zorg]

I understand the arguments, but would like to point out that the problem has not been resolved and will continue to apply. I think it would be worthwhile to mark this and similar reports in some other way.