Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Building a water object on a plain water docking tile does not correctly remove the docking tile #9591

Closed
JGRennison opened this issue Oct 2, 2021 · 0 comments

Comments

@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Oct 2, 2021

Version of OpenTTD

master

Expected result

Station::docking_station is always correct.

Actual result

Building a water object on a plain water docking tile does not correctly remove the docking tile,
in that the station(s) associated with the docking tile do not have their docking_station tile areas updated.
This can result in multiplayer desyncs. This issue is detected by the cache checks in CheckCaches.

This was noticed because of griefers placing fake water tiles around docks, which later resulted in docking_station mismatches being logged.

Steps to reproduce

  • Set the desync log level to at least 2.
  • Build a dock.
  • Build water objects (e.g. from decoration NewGRF such as AuzWaterAndLandscapeObjects) on the dock's docking tiles.
  • Note that a desync log message will be eventually logged.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 2, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 2, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 2, 2021
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 3, 2021
@TrueBrain TrueBrain closed this in e404d16 Oct 3, 2021
JGRennison added a commit to JGRennison/OpenTTD-patches that referenced this issue Oct 3, 2021
…n a docking tile (#9594)

See: OpenTTD/OpenTTD#9591
See: OpenTTD/OpenTTD#9594

Non-extended savegame bump to be applied later

(cherry picked from commit e404d16)

# Conflicts:
#	src/object_cmd.cpp
#	src/saveload/afterload.cpp
#	src/saveload/saveload.h
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Oct 16, 2021
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant