Improve OSX bit rot #6695
Merged
Improve OSX bit rot #6695
Conversation
|
Compiles and runs for me on macOS 10.12.6. I'm not competent to review the changes. I could try and trigger specific issues that the commits address if that helps. |
src/fontdetection.cpp
Outdated
|
|
||
| /* Get a file system reference for the font. */ | ||
| FSRef ref; | ||
| /* Get font reference from name. */ |
frosch123
Apr 9, 2018
Member
indentation
indentation
src/fontdetection.cpp
Outdated
| CFStringRef name = CFStringCreateWithCString(kCFAllocatorDefault, font_name, kCFStringEncodingUTF8); | ||
|
|
||
| #if (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_6) | ||
| if (MacOSVersionIsAtLeast(10, 6, 0)) { |
frosch123
Apr 9, 2018
Member
indent
indent
src/fontdetection.cpp
Outdated
| CFRelease(fontURL); | ||
| } | ||
| if (descs != NULL) CFRelease(descs); | ||
| } else |
frosch123
Apr 9, 2018
Member
indent
indent
|
Now with less spaces :) |
|
Exterminate all the spaces! |
|
Like any of us has a clue; sounds good to me! :D Tnx for taking care of Mac OS X :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
OSX APIs are an ever-moving target. Update some uses in OTTD to hopefully improve compatibility with newer OSX versions.