Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Change: Refactor window ticks into game ticks and realtime events. #6780
These changes uncouple GUI timing (used for e.g. animations, debouncing, refresh intervals) from game timing. This change is most visible when using fast-forward, although it is also noticeable on very slow savegames as well.
Timing intervals have been multiplied by 30 to convert from game ticks to milliseconds. Note that although MILLISECONDS_PER_TICK is 30, in reality I often see 30, 31 or 32ms per game tick, so some animations may differ very slightly.
These changes may need additional refactoring due to feature creep.
left a comment
It's a shame that it can't have any effect at normal speed - the GUI movement speed is very noticeable after some time on fast forward! I imagine the "solution" to that would be to effectively run the GUI on fast forward all the time, which probably isn't all that viable...