Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature: Add NotRoadTypes (NRT) #6811
The 'one big diff' approach.
16 types only, PeterN has a patch for 64, but that needs finish, tested, argued about etc. Can do that later. We make progress by not waiting for perfect eh? :)
Want to try it out? https://www.openttd.org/downloads/openttd-pullrequests/pr6811/latest.html has precompiled binaries for you! (last updated: 24th of March 2018)
Rebased by Alberth using Peter's July 2018 rebase
This builds and runs fine, but it's not clear yet:
With respect to 64 types (or not): this PR adds 64 types. It's the better option.
Crowd-sourced opinion is that this won't have enough play-test time to make it into 1.9.0 by April 2019. It has been play-tested quite a lot already, but eh. Save it for 2.0?
nielsmh left a comment
Assertion failure at tile_map.h line 91 running regression tests.
Two issues I've noticed during gameplay testing:
…ake sense. Road type and rail type are stored in separate locations, so this parameter does not make make sense as it is only used for rail bridges. Instead explicitly set the rail type in MakeRailBridgeRamp().