Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature: Allow flip of train vehicles in depot independently of NewGRF property #6846
Please explain in more detail the purpose and intentions of your patch.
The diff tells me you do two things:
For the first part, removal of EF_RAIL_FLIPS:
About the second part, changing sprite offsets:
Vehicle position offset has a story that is traceable in the tracker. Long ago, position of vehicle wasn't in the center, which brought complicated bugs and glitches. Because of this, there was introduced "EF_RAIL_FLIPS" to forbid such bugs when flipping train in depot by default. After some time, vehicle position was moved to center, but this variable wasn't reviewed, nor the flipping. I see the closure of this story is not a priority because it's convenient to keep it for other reasons, so I'll remove it from patch.
The offset part:
Basic problem is, when NewGRF author wants his (short) train to flip, he would need to define special sprites for vehicles of shorter lengths due to wrong offset in game or make other workaround. Due to this, we have flipping feature disabled in almost every NewGRFs even when there is no reason for it.
Can you please give an explanation on what is wrong with 4x zoom? If you are referencing zoom-in and zoom-out with mouse wheel, there are no problems, this patch doesn't change anything from that code. It only change basic vehicle values that are used later (not the actual drawing code) and then the GUI that is not influenced by zoom.
About the 4x zoom:
In this case for trains:
Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the open PR count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!