Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Forbid dock placement on docking area #6927

Conversation

Projects
None yet
6 participants
@SamuXarick
Copy link
Contributor

commented Oct 1, 2018

Negates dock placement if it would be blocking ship access to the docking location of another dock or of an oil rig station.

https://www.tt-forums.net/viewtopic.php?p=1176272

@SamuXarick SamuXarick force-pushed the SamuXarick:forbid-dock-placement-on-docking-area branch 2 times, most recently from 8689ea1 to f19ebe0 Oct 1, 2018

@J0anJosep

This comment has been minimized.

Copy link
Contributor

commented Nov 4, 2018

I am not keen on these types of checks. If we had to check for any action whether it will block any vehicle or any station, the code would be much larger than it is now.

@TrueBrain

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles!

@andythenorth

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

This accounts for Oil Rigs, does it account for Newgrf industries built on water? L2472 does that?

Change: Forbid dock placement on docking area
Negates dock placement if it would be blocking ship access to the docking location of another dock or of an oil rig station.

https://www.tt-forums.net/viewtopic.php?p=1176272

@SamuXarick SamuXarick force-pushed the SamuXarick:forbid-dock-placement-on-docking-area branch from f19ebe0 to 78cca2e Jan 12, 2019

@SamuXarick

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

This accounts for Oil Rigs, does it account for Newgrf industries built on water? L2472 does that?

I tried to comply with the rules found somewhere on industry_cmd.cpp

@andythenorth

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

On reflection it's not essential to provide these kind of checks. The benefit is too little for the complexity introduced, and the possibility of unintended side effects. This PR is not likely to be accepted, so I'm closing it to keep things tidy. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.