New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6898: Replace atoi() with strtoul() #6936

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@MiguelHorta
Copy link
Contributor

MiguelHorta commented Oct 10, 2018

Normalize type and parsing of generation_seed across all files
Add static_assert() to ensure correct type

@MiguelHorta MiguelHorta force-pushed the MiguelHorta:t6898/seed_parse branch from f6e51ef to 0a4a426 Oct 10, 2018

@LordAro
Copy link
Member

LordAro left a comment

Looks good - you might want to check your git config, github seems to think the commit has been authored/committed by 2 different people, neither of which is linked to your GH account

Fix #6898: Replace atoi() with strtoul()
Normalize type and parsing of generation_seed across all files
Add assert_compile() to ensure correct type

@MiguelHorta MiguelHorta force-pushed the MiguelHorta:t6898/seed_parse branch from 0a4a426 to a0f1629 Oct 10, 2018

@MiguelHorta

This comment has been minimized.

Copy link
Contributor Author

MiguelHorta commented Oct 10, 2018

Thanks for the head-ups. Indeed, my git configuration was wrong.
Unfortunately, it seems I invalidated your review while trying to fix, sorry about that :|

@orudge orudge merged commit e00908f into OpenTTD:master Oct 11, 2018

6 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
openttd/commit-checker The commit looks good
Details
openttd/linux-amd64-clang-3.8 The commit looks good
Details
openttd/linux-amd64-gcc-6 The commit looks good
Details
openttd/linux-i386-gcc-6 The commit looks good
Details
openttd/osx-10.9 The commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment