Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6864: Normalise colour use in Frame rate window #6958

Merged
merged 1 commit into from Nov 25, 2018

Conversation

@nielsmh
Copy link
Contributor

nielsmh commented Nov 1, 2018

No description provided.

@J0anJosep
Copy link
Contributor

J0anJosep commented Nov 4, 2018

Thanks for your work. The commit looks good.
Given that some strings are going to change, could you add a second commit to this PR? I had previously worked on it, and I also noticed two things that could be improved in my opinion:

  • Add {NBSP} between number and unit (it has no effect, but it is compulsory never to separate a magnitude from its unit).
  • STR_FRAMERATE_CAPTION_SMALL has a color code that is declared before a space. No effect whatsover, but trying to keep code strings clean for readibility, it would better as "{STRING2} {WHITE}({DECIMAL}x)"

You can look at this commit. Never posted the PR, as I was waiting a second opinion before changing anything.

@nielsmh nielsmh merged commit 9e30fba into OpenTTD:master Nov 25, 2018
6 checks passed
6 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
openttd/commit-checker The commit looks good
Details
openttd/linux-amd64-clang-3.8 The commit looks good
Details
openttd/linux-amd64-gcc-6 The commit looks good
Details
openttd/linux-i386-gcc-6 The commit looks good
Details
openttd/osx-10.9 The commit looks good
Details
@nielsmh nielsmh deleted the nielsmh:bug6864 branch Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.