Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements in known-bugs file #6963

Merged
merged 3 commits into from Nov 27, 2018
Merged

Conversation

@Greg-21
Copy link
Contributor

Greg-21 commented Nov 5, 2018

In these commits I did the following:

  • removed obsolete known bugs from the list, as they were fixed by @nielsmh
  • removed "FS" from issue number (because FlySpray is no longer the main bug tracking system)
  • changed the order based on the numbering of bugs
  • changed "Mac OS X" to "macOS"
  • made that lines end closer to the 80th character column
  • converted "tabs" to "spaces" (to make sure that every line doesn't much exceed the 80th character column)
  • updated the release version
  • several other less important changes.
known-bugs.txt Outdated Show resolved Hide resolved
known-bugs.txt Outdated Show resolved Hide resolved
known-bugs.txt Outdated Show resolved Hide resolved
known-bugs.txt Outdated Show resolved Hide resolved
@Greg-21

This comment has been minimized.

Copy link
Contributor Author

Greg-21 commented Nov 5, 2018

@nielsmh Since you are "only" a contributor, I'm not sure that I can trust you. There are more obsolete known bugs, I think, so this is not as important to remove these 4 right now.

A comment from any member about that would be appreciated :)

@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Nov 5, 2018

Niels literally fixed all those bugs himself...

@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented Nov 6, 2018

If any items are removed from the list, I'd argue it's better to do that in a separate commit either way. One commit to change formatting, one to change contents.

@Greg-21

This comment has been minimized.

Copy link
Contributor Author

Greg-21 commented Nov 7, 2018

I think the same as you, so that's why I already have committed them locally and still waiting to push them to remote, because I'd like to know if you are sure you fixed those known bugs, or not, and they just should be fixed. If the 2nd scenario, it would be better to have more listed bugs.

@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented Nov 7, 2018

There are no known bugs or glitches in the new Win32 and DMusic music drivers.

I haven't rigorously tested the new Fluidsynth driver, but seeing the code is very simple, any bugs are likely to be in the underlying Fluidsynth library and not OpenTTD's usage of it. I left it playing OpenMSX and other music sets on its own for a good while and didn't notice any oddities.

(It's possible to trigger some shutdown-related race conditions causing assertion errors in the Win32 music driver, when running OpenTTD under a debugger and using breakpoints that trigger during shutdown, but I haven't been able to reproduce those with a release build running outside a debugger.)

@Greg-21

This comment has been minimized.

Copy link
Contributor Author

Greg-21 commented Nov 7, 2018

Your certainty convinced me :D I just pushed the commit.

known-bugs.txt Outdated Show resolved Hide resolved
Greg-21 added 3 commits Nov 5, 2018
Converted "tabs" to "spaces", changed the order based on the numbering of bugs, made that lines end closer to the 80th character column, changed "Mac OS X" to "macOS", and several other less important changes.
Because FlySpray is no longer the main bug tracking system.
@michicc michicc merged commit d64a0a6 into OpenTTD:master Nov 27, 2018
6 checks passed
6 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
openttd/commit-checker The commit looks good
Details
openttd/linux-amd64-clang-3.8 The commit looks good
Details
openttd/linux-amd64-gcc-6 The commit looks good
Details
openttd/linux-i386-gcc-6 The commit looks good
Details
openttd/osx-10.9 The commit looks good
Details
@Greg-21 Greg-21 deleted the Greg-21:known-bugs-upd branch Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.