Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Unique ID to savegames to prevent accidental overwriting #6973

Closed
wants to merge 3 commits into from

Conversation

@damfr
Copy link
Contributor

@damfr damfr commented Nov 20, 2018

This PR adds a new randomly generated unique ID as a setting to savegames to avoid accidental overwriting of another savegame in the save dialog.
The ID is automatically generated :

  • When a new world is generated
  • When an old savegame (prior to this new version) is loaded

When the user attempts to overwrite a save with a different ID, a warning popup shows and a message is also shown in the details of the save.

@damfr damfr force-pushed the damfr:save-unique-id branch from 610c10d to 86284bf Nov 20, 2018
src/saveload/saveload.cpp Outdated Show resolved Hide resolved
src/fios_gui.cpp Outdated Show resolved Hide resolved
src/lang/english.txt Outdated Show resolved Hide resolved
src/fios_gui.cpp Outdated Show resolved Hide resolved
@damfr damfr force-pushed the damfr:save-unique-id branch from 86284bf to bdd47ed Nov 20, 2018
src/fios_gui.cpp Outdated Show resolved Hide resolved
@damfr damfr force-pushed the damfr:save-unique-id branch from bdd47ed to c87a1a8 Nov 25, 2018
src/table/settings.ini Outdated Show resolved Hide resolved
@damfr damfr force-pushed the damfr:save-unique-id branch from c87a1a8 to 5d8b9de Nov 26, 2018
@nielsmh nielsmh dismissed frosch123’s stale review Dec 1, 2018

Savegame version on setting corrected

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jan 5, 2019

We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles!

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jan 28, 2019

Closing in favor of #7128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.