Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Win32] Align sprite glyphs to the font baseline when using Uniscribe text layout #6979

Merged
merged 1 commit into from Dec 1, 2018

Conversation

@michicc
Copy link
Member

michicc commented Nov 25, 2018

Our sprite glyphs just look better when not stuck at the top of the line.

@michicc michicc added the Windows label Nov 25, 2018
@nielsmh
nielsmh approved these changes Dec 1, 2018
Copy link
Contributor

nielsmh left a comment

Seems to work just fine with English, Arabic, Hebrew, Chinese (Simplified), and Japanese. That should cover all cases.

@michicc michicc merged commit 3b8db31 into OpenTTD:master Dec 1, 2018
6 checks passed
6 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
openttd/commit-checker The commit looks good
Details
openttd/linux-amd64-clang-3.8 The commit looks good
Details
openttd/linux-amd64-gcc-6 The commit looks good
Details
openttd/linux-i386-gcc-6 The commit looks good
Details
openttd/osx-10.9 The commit looks good
Details
@michicc michicc deleted the michicc:pr/fix_uniscribe_align branch Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.