Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Spelling in code comment #6982

Closed
wants to merge 1 commit into from
Closed

Conversation

@comicsads
Copy link
Contributor

comicsads commented Nov 27, 2018

This is my first contribution to a git project but I think I did everything correctly.
Line 366 contained the word "bough" when it should be "bought"

This is my first contribution to a git project but I think I did everything correctly.
Line 366 contained the word "bough" when it should be "bought"
@planetmaker

This comment has been minimized.

Copy link
Contributor

planetmaker commented Nov 27, 2018

The automatic checks failed on grounds of the commit message. It should follow our style guide and read like "Fix: Spelling in code comment" (or similar). See https://wiki.openttd.org/Coding_style#Commit_message or the message on the commit checker: https://farm.openttd.org/jenkins/blue/organizations/jenkins/OpenTTD%2FOpenTTD/detail/PR-6982/1/pipeline

@comicsads comicsads changed the title Corrected Spelling In Comment Fix: Spelling in code comment Nov 27, 2018
@planetmaker

This comment has been minimized.

Copy link
Contributor

planetmaker commented Nov 28, 2018

Thanks, implemented in #6984. Closing this predecessor now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.