Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6974: Add filter widget to api (and a double dot from somewhere) #6985

Merged
merged 1 commit into from Dec 27, 2018

Conversation

@J0anJosep
Copy link
Contributor

J0anJosep commented Dec 1, 2018

After running scripts, it seems a new widget has been added but scripts weren't executed.
There is a double dot removal as well.
Don't have much time now and I didn't review where this changes come from, so this PR needs a review. I leave this PR as this, hoping someone can have a look at it.

@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented Dec 5, 2018

Change itself looks fine, your commit message needs to lose the parentheses around the ticket number.

Fix #6974: Add filter widget to api (and a double dot from somewhere)

@J0anJosep J0anJosep force-pushed the J0anJosep:AddFilterWidget branch from 4dd4676 to d188f22 Dec 8, 2018
@nielsmh nielsmh changed the title Fix (#6974): Add filter widget to api (and a double dot from somewhere) Fix #6974: Add filter widget to api (and a double dot from somewhere) Dec 27, 2018
@nielsmh nielsmh merged commit 8890926 into OpenTTD:master Dec 27, 2018
6 checks passed
6 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
openttd/commit-checker The commit looks good
Details
openttd/linux-amd64-clang-3.8 The commit looks good
Details
openttd/linux-amd64-gcc-6 The commit looks good
Details
openttd/linux-i386-gcc-6 The commit looks good
Details
openttd/osx-10.9 The commit looks good
Details
@J0anJosep J0anJosep deleted the J0anJosep:AddFilterWidget branch Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.