Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upChange: AI/GS ScriptBridge::GetName takes one extra parameter to refer the vehicle type #6988
Conversation
SamuXarick
force-pushed the
SamuXarick:ScriptBridge-GetName
branch
3 times, most recently
from
2982d9a
to
f1efe27
Dec 21, 2018
This comment has been minimized.
This comment has been minimized.
|
We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles! |
SamuXarick
force-pushed the
SamuXarick:ScriptBridge-GetName
branch
from
f1efe27
to
42b9ccd
Jan 9, 2019
LordAro
requested changes
Jan 10, 2019
SamuXarick
force-pushed the
SamuXarick:ScriptBridge-GetName
branch
from
42b9ccd
to
79272cf
Jan 11, 2019
LordAro
approved these changes
Jan 17, 2019
LordAro
reviewed
Jan 17, 2019
| @@ -253,7 +253,7 @@ function Regression::Bridge() | |||
| if (AIBridge.IsValidBridge(i)) j++; | |||
| print(" Bridge " + i); | |||
| print(" IsValidBridge(): " + AIBridge.IsValidBridge(i)); | |||
| print(" GetName(): " + AIBridge.GetName(i)); | |||
| print(" GetName(): " + AIBridge.GetName(i, AIVehicle.VT_RAIL)); | |||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SamuXarick commentedDec 21, 2018
When I was working with my AI and wanted to retrieve the name of bridges, I was always getting the rail name version of that bridge even though I was working with roads. With this change I can now chose from all three vehicle types that have bridges. It's merely a name display issue.