New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: AI/GS ScriptBridge::GetName takes one extra parameter to refer the vehicle type #6988

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@SamuXarick
Copy link
Contributor

SamuXarick commented Dec 21, 2018

When I was working with my AI and wanted to retrieve the name of bridges, I was always getting the rail name version of that bridge even though I was working with roads. With this change I can now chose from all three vehicle types that have bridges. It's merely a name display issue.

@SamuXarick SamuXarick force-pushed the SamuXarick:ScriptBridge-GetName branch 3 times, most recently from 2982d9a to f1efe27 Dec 21, 2018

@TrueBrain

This comment has been minimized.

Copy link
Member

TrueBrain commented Jan 5, 2019

We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles!

@SamuXarick SamuXarick force-pushed the SamuXarick:ScriptBridge-GetName branch from f1efe27 to 42b9ccd Jan 9, 2019

Show resolved Hide resolved bin/game/compat_1.2.nut

@SamuXarick SamuXarick force-pushed the SamuXarick:ScriptBridge-GetName branch from 42b9ccd to 79272cf Jan 11, 2019

@@ -253,7 +253,7 @@ function Regression::Bridge()
if (AIBridge.IsValidBridge(i)) j++;
print(" Bridge " + i);
print(" IsValidBridge(): " + AIBridge.IsValidBridge(i));
print(" GetName(): " + AIBridge.GetName(i));
print(" GetName(): " + AIBridge.GetName(i, AIVehicle.VT_RAIL));

This comment has been minimized.

@LordAro

LordAro Jan 17, 2019

Member

Hmm, are there any road bridges you can add to the test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment