Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: use vcpkg integration in Visual Studio #6989

Closed
wants to merge 2 commits into from
Closed

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Dec 25, 2018

Removes the need for us to provide OpenTTD-useful package

Copy link
Member

@TrueBrain TrueBrain left a comment

Sweet :D

Please also update https://github.com/OpenTTD/OpenTTD/blob/master/README.md#70-compiling with the new instructions in the Pull Request. Otherwise a lot of people will be a bit confused :)

src/stdafx.h Show resolved Hide resolved
Removes the need for us to provide OpenTTD-useful package
@glx22
Copy link
Contributor Author

@glx22 glx22 commented Dec 25, 2018

https://github.com/OpenTTD/OpenTTD/blob/master/docs/Readme_Windows_MSVC.txt will need an update too, but it's a lot bigger than the scope of this PR (and I'm not good at documentation)

Copy link
Member

@TrueBrain TrueBrain left a comment

Sorry, I disagree; it is not bigger than the scope of this PR to make that file at least factual correct (or at least for the parts references in this PR). Even if you are not good at documentation, doing what you did for README.md is always the least we can do :) If we don't fix things like that, we make it a lot harder for new people, which is counterproductive :)

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 26, 2018

Added the documentation (and this PR) as part of #6991. Let's continue there :)

@TrueBrain TrueBrain closed this Dec 26, 2018
@glx22 glx22 deleted the vcpkg branch Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants