Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [AzurePipelines] download the correct Windows Dependency artifact #6996

Merged
merged 2 commits into from Dec 28, 2018

Conversation

@TrueBrain
Copy link
Member

TrueBrain commented Dec 27, 2018

No description provided.

@TrueBrain TrueBrain force-pushed the TrueBrain:azure branch 8 times, most recently from c99e8e4 to ebc95c8 Dec 27, 2018
@TrueBrain TrueBrain force-pushed the TrueBrain:azure branch 2 times, most recently from b357a50 to d0b6cad Dec 28, 2018
It turns out that Azure Pipelines has a lot of issues downloading
an artifact from your own project if it is triggered from a fork.
From what I could deduce, this is because the API requires a valid
token, which is not set (correctly?) when triggered from a fork.
As it is nicer anyway to publish the Windows Dependencies on GitHub,
it is now published there (and updated at least every week), and
we use the files from GitHub as our dependency.
@TrueBrain TrueBrain force-pushed the TrueBrain:azure branch from d0b6cad to 7b2f90c Dec 28, 2018
@PeterN
PeterN approved these changes Dec 28, 2018
@TrueBrain TrueBrain merged commit d8f6c80 into OpenTTD:master Dec 28, 2018
1 check passed
1 check passed
OpenTTD CI Build #20181228.5 succeeded
Details
@TrueBrain TrueBrain deleted the TrueBrain:azure branch Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.