Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: show 'Max. Power' for vehicles rather than 'Power' #6997

wants to merge 1 commit into from


Copy link

@andythenorth andythenorth commented Dec 29, 2018

It's possible for vehicles to change power, most likely due to checking railtype, also other vars in the consist.

This can be confusing for player in purchase / 'available trains' lists as the power value shown may not match the power value of the vehicle when built in a specific depot.

We handle other cases of variable properties by prefixing 'Max.', e.g. TE, speed, reliability etc.
I have done the same here as it seems by far the simplest solution, just a string change.

I rejected complicated solutions such as returning a range of power values to the cb in purchase list, or suppressing the display of the power value and replacing with extra buy menu text.

It's the responsibility of newgrf authors to return the correct value for max power to the purchase list.

Changed both purchase list and vehicle preview windows. Didn't change vehicle info window, as that should display actual current power IMHO.

Issue (with vehicle set to use lowest power in purchase list, as safest way to not ruin player's network)
Fix in context of purchase window (with vehicle set to use maximum power in purchase list)
Fix in context of preview window

…e and preview windows - covers better case of variable power
Copy link
Contributor Author

Doesn't work for cases where vehicles power can be increased by adding wagons, because in that case there is no meaningful max. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant