Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: [Win32] regression testing with MSVC #7002

Merged
merged 4 commits into from Jan 5, 2019
Merged

Conversation

@glx22
Copy link
Contributor

glx22 commented Dec 31, 2018

No description provided.

@glx22 glx22 force-pushed the glx22:regression branch from a3152ba to edbf721 Dec 31, 2018
@glx22
Copy link
Contributor Author

glx22 commented Dec 31, 2018

If the CI tries the updated version, it should now fail at regression because OpenGFX is probably not present

@TrueBrain
Copy link
Member

TrueBrain commented Dec 31, 2018

I canceled the build, as without gfx, it just "hangs" for ever. Which is rather annoying.

Guess you need something like this:

- bash: | set -ex mkdir -p ~/Documents/OpenTTD/baseset cd ~/Documents/OpenTTD/baseset curl -L https://binaries.openttd.org/extra/opengfx/0.5.2/opengfx-0.5.2-all.zip > opengfx-0.5.2-all.zip unzip opengfx-0.5.2-all.zip rm -f opengfx-0.5.2-all.zip displayName: 'Install OpenGFX'

Before Build step. Feel free to modify it, or make it non-bash (that would be optimal :D). I have no clue if the destination is correct etc. Never got to test it ;)

Additionally, a question: if it is just a vbs file to run, is it needed to have different configuration for the regression? Can't we just have the Debug/Release, and that we run the vbs script after that to run regression? (honest question)

@glx22 glx22 force-pushed the glx22:regression branch from edbf721 to bf7d792 Dec 31, 2018
@glx22
Copy link
Contributor Author

glx22 commented Dec 31, 2018

I think it hangs because a message box opens when the gfx is not found.

There are extra steps around the vbs file run, that's why I added a projects in the solution. And the extra configuration were to run regression from MSBuild, but indeed it's possible to do it from outside (the regression project just calls a batch script).

The main question is where to put openGFX :). Looking in README there are many options, and I don't know what's best for azure pipelines. I think the easy way is to put it directly in bin/baseset, but I'm not sure.

For now I removed the added configurations as they were somehow overkill. And I'm working on a new yml version.

@glx22 glx22 force-pushed the glx22:regression branch from b9e429f to 68b02a3 Dec 31, 2018
azure-pipelines-ci.yml Outdated Show resolved Hide resolved
@@ -300,7 +300,7 @@ void CreateConsole()
if (_has_console) return;
_has_console = true;

AllocConsole();
if (!AllocConsole()) return;

This comment has been minimized.

Copy link
@LordAro

LordAro Dec 31, 2018

Member

maybe a comment?

@glx22
Copy link
Contributor Author

glx22 commented Dec 31, 2018

Ok it fails, but it's a progress (no hang this time). Looking at the logs my install GFX task doesn't work, and the batch fails because it's not run in the VS environment

@glx22 glx22 force-pushed the glx22:regression branch from 68b02a3 to 6443ed5 Dec 31, 2018
@glx22 glx22 force-pushed the glx22:regression branch from 6443ed5 to 2202e2e Dec 31, 2018
@LordAro
LordAro approved these changes Jan 5, 2019
@glx22 glx22 merged commit 96b961c into OpenTTD:master Jan 5, 2019
1 check passed
1 check passed
OpenTTD CI Build #20190101.2 succeeded
Details
@glx22 glx22 deleted the glx22:regression branch Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.