Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929) #7009
This PR tries to fix that:
Also, some minor spelling mistakes on comments.
Please, note that this PR needs an accurate review.
Even as road vehicles can turn around, I wouldn't check two-way for road vehicles when looking for a depot:
I think that disabling two-way checks (as in the current PR) will simplify the whole issue. But I am not fully convinced of this solution. It would be ok that road vehicles checked the opposite direction in some cases, but I don't know whether it is worth it.
nielsmh left a comment
Please fix the commit messages (rebase -i).
The first commit message talks about "road vehicles" when it should be "road stations". (Road vehicles can never be tiles.)
The last commit should be "Docs" rather than "Fix", suggestion:
Also try to find a way to not repeat YAPF and NPF in the other commit messages, it looks very silly with it first in a tag and then first word in the sentence.