Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Desert tiles are now half-desert if a neighboured tile is non… #7015

Merged
merged 1 commit into from Jan 9, 2019

Conversation

@andythenorth
Copy link
Contributor

andythenorth commented Jan 5, 2019

…-desert or sea/coast. (patch by frosch123) #4754

Patch is by frosch123, I'm gravedigging it.

TL;DR: increase number of cases where desert tiles will show half-desert.

See my testing notes here #4754 (comment)

Scenario Editor in 1.8.0
4754-1 8 0
Scenario Editor with #4754 patch applied - note half tile next to river compared to 1.8.0
4754-patched

Rivers built during random map gen are already created with non-desert tiles next to them, but the appearance is improved with this patch.

…-desert or sea/coast. (patch by frosch123) #4754
Copy link
Contributor

planetmaker left a comment

Nice and works as intended. And it's something which scratches my own itch. Approved!

@planetmaker planetmaker merged commit ad5a9da into OpenTTD:master Jan 9, 2019
1 check passed
1 check passed
OpenTTD CI Build #20190105.16 succeeded
Details
@SamuXarick

This comment has been minimized.

Copy link
Contributor

SamuXarick commented Jan 21, 2019

I don't get the same results.
1.8.0
screenshot 88

Master
screenshot 89

@andythenorth

This comment has been minimized.

Copy link
Contributor Author

andythenorth commented Jan 21, 2019

Verified: the behaviour differs significantly depending on order of operation:

I have no idea if this matters. My assumption based on the original #4754 issue is that this was the desired behaviour. The inconsistency looks correct to me: using different tools creates different results.

nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.