Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Conditional order for max. reliability (patch by Cirdan, #6360) #7017

Merged
merged 1 commit into from Jan 5, 2019

Conversation

@Eddi-z
Copy link
Contributor

Eddi-z commented Jan 5, 2019

Note: not tested myself

@planetmaker

This comment has been minimized.

Copy link
Contributor

planetmaker commented Jan 5, 2019

+1

Copy link
Contributor

planetmaker left a comment

I like the patch

@planetmaker planetmaker merged commit 13056ae into OpenTTD:master Jan 5, 2019
1 check passed
1 check passed
OpenTTD CI Build #20190105.17 succeeded
Details
@michicc

This comment has been minimized.

Copy link
Member

michicc commented Jan 6, 2019

Did anyone check loading of old savegames? As far as I can see, OrderConditionVariable is directly stored in the save game, thus modifying the enum in the middle breaks old saves.

@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented Jan 6, 2019

@michicc that sounds plausible, will test. I think the best course of action is to just add another commit with the needed savegame fixups, rather than reverting and reworking.

@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented Jan 6, 2019

Can confirm the bug is present.

Saving this orders list in 1.8.0:
image

Loads as this orders list after this patch is applied:
image

nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Jan 6, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Jan 6, 2019
nielsmh added a commit that referenced this pull request Jan 6, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.