Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't increase motion counter while train is waiting at non-path… #7018

Merged

Conversation

@andythenorth
Copy link
Contributor

andythenorth commented Jan 5, 2019

… signals (Author: frosch123) #5877

Tested this compiles. Don't know if it solves the issue. See original discussion in #5877, pikka provides a test grf there.

… signals (Author: frosch123) #5877
@andythenorth

This comment has been minimized.

Copy link
Contributor Author

andythenorth commented Jan 6, 2019

Now tested. Works as expected.

  • in #5877 pikka provides a test grf and savegame
  • the savegame contains 2 trains, stopped at path and non-path signals
  • the trains are animated to spin if moving
  • in master, the train at the non-path signal spins, the train at path signal does not
  • with 5877 applied, neither train spins, this is the desired result
Copy link
Contributor

planetmaker left a comment

Sounds reasonable.

@planetmaker planetmaker merged commit e934f09 into OpenTTD:master Jan 9, 2019
1 check passed
1 check passed
OpenTTD CI Build #20190105.25 succeeded
Details
nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.