Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't increase motion counter while train is waiting at non-path… #7018

Merged

Conversation

andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 5, 2019

… signals (Author: frosch123) #5877

Tested this compiles. Don't know if it solves the issue. See original discussion in #5877, pikka provides a test grf there.

@andythenorth
Copy link
Contributor Author

@andythenorth andythenorth commented Jan 6, 2019

Now tested. Works as expected.

  • in #5877 pikka provides a test grf and savegame
  • the savegame contains 2 trains, stopped at path and non-path signals
  • the trains are animated to spin if moving
  • in master, the train at the non-path signal spins, the train at path signal does not
  • with 5877 applied, neither train spins, this is the desired result

Copy link
Contributor

@planetmaker planetmaker left a comment

Sounds reasonable.

@planetmaker planetmaker merged commit e934f09 into OpenTTD:master Jan 9, 2019
1 check passed
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants