Add: generate_widget.vbs to allow script_window.hpp enums generation … #7022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
force-pushed
the
generate_widget
branch
2 times, most recently
from
b127a13
to
dc9e2c7
Compare
nielsmh
requested changes
Jan 20, 2019
I ran generate_widget.vbs and it deleted everything in script_window.hpp.
|
Turns out the issue is that the VBScript version doesn't handle Unix line endings at all. If the input file has Either the VBScript should handle both types of line endings, or it should at least abort if the file doesn't seem to use DOS-style. |
|
It now falls back to \n if \r\n fails |
…for users unable to run bash/gawk scripts
nielsmh
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…for users unable to run bash/gawk scripts