Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: generate_widget.vbs to allow script_window.hpp enums generation … #7022

Merged
merged 2 commits into from Jan 23, 2019

Conversation

@glx22
Copy link
Contributor

glx22 commented Jan 6, 2019

…for users unable to run bash/gawk scripts

@glx22 glx22 force-pushed the glx22:generate_widget branch 2 times, most recently from b127a13 to dc9e2c7 Jan 8, 2019
@LordAro LordAro requested a review from nielsmh Jan 10, 2019
Copy link
Contributor

nielsmh left a comment

I ran generate_widget.vbs and it deleted everything in script_window.hpp.

@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented Jan 20, 2019

Turns out the issue is that the VBScript version doesn't handle Unix line endings at all. If the input file has \n only for line endings, the file is considered a single line, and just cleared out.

Either the VBScript should handle both types of line endings, or it should at least abort if the file doesn't seem to use DOS-style.

@glx22 glx22 force-pushed the glx22:generate_widget branch from dc9e2c7 to dd237bc Jan 20, 2019
@glx22

This comment has been minimized.

Copy link
Contributor Author

glx22 commented Jan 20, 2019

It now falls back to \n if \r\n fails

@glx22 glx22 force-pushed the glx22:generate_widget branch from dd237bc to bc7ff79 Jan 23, 2019
@glx22 glx22 merged commit 7292591 into OpenTTD:master Jan 23, 2019
1 check passed
1 check passed
OpenTTD CI Build #20190123.10 succeeded
Details
@glx22 glx22 deleted the glx22:generate_widget branch Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.