Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rail fences in snow or desert #7024

Closed
wants to merge 2 commits into from
Closed

Rail fences in snow or desert #7024

wants to merge 2 commits into from

Conversation

@pi1985
Copy link

pi1985 commented Jan 6, 2019

This allow to draw rail fences in snow or desert tiles

@Eddi-z

This comment has been minimized.

Copy link
Contributor

Eddi-z commented Jan 6, 2019

that diff looks way too large for such a simple feature, maybe split it up into more logical sections? makes it easier to review

@pi1985

This comment has been minimized.

Copy link
Author

pi1985 commented Jan 6, 2019

Hmm... this patch makes simple feature, there isn't logical parts. You may mean changes in newgrf_commons.cpp, water_cmd.cpp - corrects showing snow background.
Without other changes game crashes or can't compile.

@andythenorth

This comment has been minimized.

Copy link
Contributor

andythenorth commented Jan 6, 2019

This PR is against issue #6315

Copy link
Contributor

nielsmh left a comment

Separate the change into at least two commits. First change the scheme for fences to your new storage format, without adding the snow/desert logic. Then a separate commit adding the snow/desert logic to this.

You also need to use the correct commit message format, otherwise the PR will be rejected by the automated checks. See the wiki for this.

@pi1985 pi1985 closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.