Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replace duplicate town name "Huacho" #7038

Merged
merged 1 commit into from Jan 12, 2019

Conversation

@nikolas
Copy link
Member

nikolas commented Jan 12, 2019

Huacho appears twice in the Spanish town names list. This change removes
the second one.

This will have the effect of altering many town names in any older
savegame using Latin American town names. I think that's an
acceptable side effect for a new OpenTTD release, but if you have a
better solution let me know. Maybe some type of null "Dummy" value here?

@James103

This comment has been minimized.

Copy link
Contributor

James103 commented Jan 12, 2019

Why don't you pick a random Spanish town name that's not already on the Spanish town name list to replace the second "Huacho"?

Huacho appears twice in the Spanish town names list. This change removes
the second one, and replaces it with a new one: Medellin.
@nikolas nikolas force-pushed the nikolas:remove-dup-town-name branch from 961b89e to d973191 Jan 12, 2019
@nikolas

This comment has been minimized.

Copy link
Member Author

nikolas commented Jan 12, 2019

Good idea! That's a better solution - I've replaced it with Medellín. That will have a lot less effect on existing savegames.

@nikolas nikolas changed the title Fix: Remove duplicate town name "Huacho" Fix: Replace duplicate town name "Huacho" Jan 12, 2019
Copy link
Contributor

andythenorth left a comment

Looks good. For diligence, I also checked the unicode escape, it's correctly "í".

@planetmaker planetmaker merged commit 82e530b into OpenTTD:master Jan 12, 2019
1 check passed
1 check passed
OpenTTD CI Build #20190112.4 succeeded
Details
nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
Huacho appears twice in the Spanish town names list. This change removes
the second one, and replaces it with a new one: Medellin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.