Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #6887: Highlight tiles within local authority of towns #7047

Closed
wants to merge 2 commits into from

Conversation

@GabdaZM
Copy link
Contributor

GabdaZM commented Jan 12, 2019

Reworked version of Add #6887: Option to show zone inside local authority boundary of towns #7025
Caching the information on which tiles to highlight instead of calculating it on every redraw.
Currently using the first bit of _me.m8 to show a proof of concept, I can move it to a separate cache if this caching approach is better than the recalculating approach.

@LordAro LordAro requested a review from PeterN Jan 12, 2019
src/town_cmd.cpp Outdated Show resolved Hide resolved
@GabdaZM GabdaZM force-pushed the GabdaZM:boundary_cached branch from 7dbdd61 to dc5eefb Jan 13, 2019
@GabdaZM GabdaZM force-pushed the GabdaZM:boundary_cached branch from dc5eefb to 142d12c Jan 14, 2019
@GabdaZM

This comment has been minimized.

Copy link
Contributor Author

GabdaZM commented Jan 15, 2019

Now it uses a separate map array, not _m or _me.

@GabdaZM GabdaZM force-pushed the GabdaZM:boundary_cached branch from 142d12c to 70924da Jan 17, 2019
@GabdaZM

This comment has been minimized.

Copy link
Contributor Author

GabdaZM commented Jan 17, 2019

Should I break this down into two commits? One for introducing the map cache array, and a second for the town related modifications.

GabdaZM added 2 commits Jan 18, 2019
Store cache data about map tiles.
Does not get stored in save fiels.
Can be found at town information > local authority window
Turn on/off for each town individually
@GabdaZM GabdaZM force-pushed the GabdaZM:boundary_cached branch from 70924da to feaf434 Jan 18, 2019
@nielsmh nielsmh added the wip label Jan 25, 2019
@glx22 glx22 removed the wip label Jan 27, 2019
@GabdaZM

This comment has been minimized.

Copy link
Contributor Author

GabdaZM commented Jan 27, 2019

I think it can go to review.

@stale

This comment has been minimized.

Copy link

stale bot commented Feb 26, 2019

This pull request has been automatically marked as stale because it has not had any activity in the last month.
Please feel free to give a status update now, ping for review, or re-open when it's ready.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Feb 26, 2019
@stale stale bot closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.